Skip to content

Comments

Fixing a typo inside the module yaml files for most hosts across tiers (enable:: ---> enable:)#1926

Closed
fabiolrdiniz wants to merge 1 commit intoJCSDA:developfrom
fabiolrdiniz:bugfix/fix4yaml
Closed

Fixing a typo inside the module yaml files for most hosts across tiers (enable:: ---> enable:)#1926
fabiolrdiniz wants to merge 1 commit intoJCSDA:developfrom
fabiolrdiniz:bugfix/fix4yaml

Conversation

@fabiolrdiniz
Copy link
Contributor

@fabiolrdiniz fabiolrdiniz commented Feb 19, 2026 •
edited
Loading

Description

This PR fixes a typo inside the module yaml files for most hosts across tiers (enable:: ---> enable:).

Dependencies

None.

Issues addressed

Not created yet... needs confirmation if it's really an issue.

Applications affected

None.

Systems affected

None.

Testing

  • CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not
    • GitHub actions CI tests pass
    • GitHub actions CI tests do not pass (provide explanation)
    • GitHub actions CI tests skipped (provide explanation if necessary)
  • New tests added: List and describe any new tests added to GitHub actions
    • ...
  • Additional testing: Add information on any additional tests conducted
    • ...

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.
  • All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged

@fabiolrdiniz fabiolrdiniz changed the title Fixing a typo inside the module yaml files for most tiers (enable:: ---> enable:) Fixing a typo inside the module yaml files for most hosts across tiers (enable:: ---> enable:) Feb 19, 2026
@climbfuji
Copy link
Collaborator

climbfuji commented Feb 19, 2026

This is not a typo, this is intentional. :: means overwriting the existing config for that particular section, not updating "in place." We definitely don't want the latter.

@fabiolrdiniz
Copy link
Contributor Author

fabiolrdiniz commented Feb 19, 2026 •
edited
Loading

@climbfuji et al., I don't know what the next steps are from here. Could you confirm this is a typo? Thanks!

Same time as above... thanks!

climbfuji
climbfuji requested changes Feb 19, 2026
View reviewed changes
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment, this is intentional. We should close this PR.

@fabiolrdiniz
Copy link
Contributor Author

fabiolrdiniz commented Feb 19, 2026

Not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@climbfuji climbfuji climbfuji requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabiolrdiniz @climbfuji